ROX-32966: Add disabling label for the konflux retests by kurlov · Pull Request #81 · stackrox/actions

kurlov · 2026-02-04T18:32:45Z

Testing: https://github.com/stackrox/test-gh-actions/pull/240

.github/workflows/retest-konflux-builds.yml

kurlov · 2026-02-04T18:42:17Z

.github/workflows/retest-konflux-builds.yml

      github.event.check_run.conclusion == 'failure' &&
-      startsWith(github.event.check_run.name, 'Red Hat Konflux')
+      startsWith(github.event.check_run.name, 'Red Hat Konflux') &&
+      !contains(github.event.check_run.pull_requests[0].labels.*.name, 'disable-konflux-auto-retest')


we know that there is a least one PR associated with the check (see check above). My understanding is that the Konflux check might have multiple PRs only when the same commit is used in those PRs. I assume it's quite rare and unique scenario so I believe [0] is correct instead of * (we don't want to disable if at least one PR has label)

Above you have github.event.check_run.pull_requests[0] != null. How does it evaluate when there are no pull requests? MintMaker does this when we configure automerge: branch, i.e. in https://github.com/stackrox/operator-index/blob/master/.github/renovate.json5#L51

Does it evaluate as "false" or does it crash GHA with sort-of a NullPointerException or is the result of github.event.check_run.pull_requests[0] equal to undefined and the expression github.event.check_run.pull_requests[0] != null weirdly evaluates to true?

Wouldn't it be more robust to check length(github.event.check_run.pull_requests) == 1 if such thing is possible?

My bad, I didn't reflect the last changes. So the latest approach (which you have already tested in the https://github.com/stackrox/test-gh-actions/pull/240) is to pull actual label value directly from GH API instead of relying on event data. Your previous testing proofed that event data (github.event.check_run.pull_requests[0].labels.*.name) might be outdated. So I've updated the PR and also changed null check to github.event.check_run.pull_requests.length > 0

msugakov

Regarding

No description provided.

Is there any way you can test this before merging to see if it really works?

kurlov · 2026-02-05T09:53:23Z

Is there any way you can test this before merging to see if it really works?

I planned to test it with this PR, but looks like konflux is not starting for that repo ATM. https://github.com/stackrox/test-gh-actions/pull/236. Looks like this testing Konflux app was deleted. I will add a new one

msugakov · 2026-02-06T09:43:04Z

Slack thread: https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1769803852015449

msugakov

Given now it passes testing, I've a couple of things to clarify.

.github/workflows/retest-konflux-builds.yml

msugakov · 2026-02-10T11:00:18Z

.github/workflows/retest-konflux-builds.yml

      github.event.check_run.conclusion == 'failure' &&
-      startsWith(github.event.check_run.name, 'Red Hat Konflux')
+      startsWith(github.event.check_run.name, 'Red Hat Konflux') &&
+      !contains(github.event.check_run.pull_requests[0].labels.*.name, 'disable-konflux-auto-retest')


Above you have github.event.check_run.pull_requests[0] != null. How does it evaluate when there are no pull requests? MintMaker does this when we configure automerge: branch, i.e. in https://github.com/stackrox/operator-index/blob/master/.github/renovate.json5#L51

Does it evaluate as "false" or does it crash GHA with sort-of a NullPointerException or is the result of github.event.check_run.pull_requests[0] equal to undefined and the expression github.event.check_run.pull_requests[0] != null weirdly evaluates to true?

Wouldn't it be more robust to check length(github.event.check_run.pull_requests) == 1 if such thing is possible?

msugakov · 2026-02-11T11:52:29Z

.github/workflows/retest-konflux-builds.yml

+          if echo "$CURRENT_LABELS" | grep -q "^disable-konflux-auto-retest$"; then
+            echo "Skipping retest: disable-konflux-auto-retest label is present"
+            exit 0
+          fi


It seems like a new implementation that you landed 20 hours ago (according to GitHub). When I look at last comments/updates in https://github.com/stackrox/test-gh-actions/pull/240, they are from 2 days ago (according to GitHub).

Would you like to test the change?

msugakov · 2026-02-11T11:59:48Z

.github/workflows/retest-konflux-builds.yml

+          CURRENT_LABELS=$(gh api "repos/${{ github.repository }}/pulls/$PR_NUMBER" --jq '.labels[].name')
+          if echo "$CURRENT_LABELS" | grep -q "^disable-konflux-auto-retest$"; then


Why gh api, can't something like this work?

$ gh pr view --json labels --jq '.labels[].name' https://github.com/stackrox/stackrox/pull/18943

Please use quoting around command substitution:
VAR=$(command) - wrong
VAR="$(command)" - better

There's probably no need to define a variable to use it once.
Instead of

CURRENT_LABELS="$(gh ...)" if echo "$CURRENT_LABELS" | grep ...; then

you can write

if gh ... | grep ...; then

The gh api is used in other lines so for consistency it's better to use gh api as well. But you are right that gh pr view can also be used.

Added quoting. My bad, I always forget about it

I would prefer to have two lines. Yes, it's slightly verbose but it's more readable

.github/workflows/retest-konflux-builds.yml

Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>

msugakov · 2026-03-12T13:24:32Z

.github/workflows/retest-konflux-builds.yml

        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          RETEST_COMMAND: ${{ inputs.retest_command }}
        run: |


Please add set -euo pipefail mantra here too.

Add disabling label for the konflux retests

18c1f78

kurlov requested a review from a team as a code owner February 4, 2026 18:32

kurlov commented Feb 4, 2026

View reviewed changes

.github/workflows/retest-konflux-builds.yml Outdated Show resolved Hide resolved

kurlov requested a review from msugakov February 4, 2026 18:33

kurlov commented Feb 4, 2026

View reviewed changes

msugakov reviewed Feb 5, 2026

View reviewed changes

msugakov reviewed Feb 10, 2026

View reviewed changes

kurlov and others added 2 commits February 10, 2026 15:55

Merge branch 'main' into akurlov/ROX-32966-add-disabling-label

14c6ca4

Change the implementation to reading actual labels before posting retest

5e51585

kurlov requested a review from msugakov February 10, 2026 15:24

Change null check

c66a250

msugakov reviewed Feb 11, 2026

View reviewed changes

.github/workflows/retest-konflux-builds.yml Show resolved Hide resolved

kurlov and others added 2 commits March 11, 2026 14:44

Update .github/workflows/retest-konflux-builds.yml

1da5363

Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>

Add quoting around command

3881168

kurlov requested a review from msugakov March 11, 2026 20:09

msugakov reviewed Mar 12, 2026

View reviewed changes

Review comments

0b16f1b

		CURRENT_LABELS=$(gh api "repos/${{ github.repository }}/pulls/$PR_NUMBER" --jq '.labels[].name')
		if echo "$CURRENT_LABELS" \| grep -q "^disable-konflux-auto-retest$"; then

Conversation

kurlov commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

msugakov left a comment

Choose a reason for hiding this comment

Uh oh!

kurlov commented Feb 5, 2026

Uh oh!

msugakov commented Feb 6, 2026

Uh oh!

msugakov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kurlov commented Feb 4, 2026 •

edited

Loading